Feature: Added HSTS header support into ssl vhost. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nginx::vhost I have added $header_hsts. This option, when defined
will set "add_header Strict-Transport-Security "${header_hsts}";".
There is also some trailing whitespace that I have cleaned up.
|
It might be better to have a generic header parameter to which any header could be added (perhaps using a hash), instead of adding specific parameters for every HTTP header. |
|
Hi @actown, the generic header parameter I suggested was added in #208, and the example in the PR description matches your use case. I'd suggest closing this in favor of that solution. I'm aware of this nginx ticket: http://trac.nginx.org/nginx/ticket/289. Perhaps if/when this is implemented in nginx a new PR could be opened on this module to take advantage of it. |
|
Awesome, just trying to drive adoption of HSTS which is why I went this route. Thanks for pointing out the nginx ticket as it brings up a few good points about HSTS in nginx. Will close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nginx::vhost I have added $header_hsts. This option, when defined
will set "add_header Strict-Transport-Security "${header_hsts}";".
There is also some trailing whitespace that I have cleaned up.
Comments and suggestions welcome.